Don't allow equal query and schema paths #179
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 16, 2019
|
See #180 for an alternative to this change |
|
I'd prefer #180 since it allows the same path/file. |
|
Great, closing this in favor of merging #180 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment (without PR #178), this config file causes sqlc to panic:
{ "version": "1", "packages": [ { "name": "db", "emit_json_tags": true, "emit_prepared_queries": false, "path": "db", "queries": "db.sql", "schema": "db.sql" } ] }sqlc can't handle the situation where the
queriesvalue is equal to theschemavalue.While #178 fixes the panic from a technical point of view and prevents sqlc from panicking in other situations, this PR checks if the paths are the same and informs the user if necessary.